Skip to content

Create two UnitTestBot plugin versions for IC and IU #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2023
Merged

Create two UnitTestBot plugin versions for IC and IU #2491

merged 3 commits into from
Aug 14, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Aug 9, 2023 •
edited
Loading

Description

We decided two create two versions of our plugin:

  1. For Intellij Ultimate: all supported features
  2. For Intellij Community: Java + Spring + Python

How to test

Automated tests: standard UTBot pipelines; note that yaml scripts were changed
Manual tests: some kind of regression for both plugin editions

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request lang-python Issue is related to python support lang-javascript Issue is related to JavaScript support comp-spring Issue is related to Spring projects support labels Aug 9, 2023
@EgorkaKulikov EgorkaKulikov changed the title New artifacts division Create two UnitTestBot plugin versions for IC and IU Aug 10, 2023
denis-fokin
denis-fokin reviewed Aug 10, 2023
View reviewed changes
@alisevych
Copy link
Member

@denis-fokin @EgorkaKulikov @Markoutte
Here are the two plugins generated from this branch:
https://github.com/UnitTestBot/UTBotJava/actions/runs/5819371184

Markoutte
Markoutte approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@Markoutte Markoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only question I have is about how these both versions can be published, or the only one is going to be published? I think, this question should be discussed with @Vassiliy-Kudryashov

alisevych
alisevych reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@alisevych alisevych left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do NOT merge.
Testing in progress
@tyuldashev has found an issue with JS in IU plugin, investigating

@alisevych
Copy link
Member

alisevych commented Aug 14, 2023 •
edited
Loading

@tyuldashev has found an issue with JS in IU plugin, investigating

The issues in JS test generation are old, not related to these changes:

PR Approved.

@alisevych alisevych merged commit 0312936 into main Aug 14, 2023
@alisevych alisevych deleted the egor/new_artifacts_division branch August 14, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Markoutte Markoutte Markoutte approved these changes

@denis-fokin denis-fokin denis-fokin approved these changes

@alisevych alisevych alisevych approved these changes

Assignees
No one assigned
Labels
comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request lang-javascript Issue is related to JavaScript support lang-python Issue is related to python support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EgorkaKulikov @alisevych @Markoutte @denis-fokin